[Bug] PrimeKB/Meridian LED indicator lights won't turn off. · qmk/qmk_firmware#11755

2021-02-01T02:31:09.000Z

[Meridian](https://github.com/qmk/qmk_firmware/tree/master/keyboards/primekb/meridian)'s LED indicator lights won't turn off. Further more, it seems like `rgblight_setrgb_at` can no longer control the LEDs, which was previously working in the [initial commit](https://github.com/qmk/qmk_firmware/commit/f079dd90ed88fd29b7e5bbdd3496742f3afeff4e). ## Describe the Bug It seems like `rgblight_setrgb_at` no longer works properly for the Meridian firmwares (both VIA & default) on master. I'm not sure what could have caused it or if other STM32 related PCBs have the same issue. After git-bitsecting, I have narrowed it down to [this commit](https://github.com/qmk/qmk_firmware/commit/c66df1664497546f32662409778731143e45a552) to be the source of the problem. ## System Information - Keyboard: - Revision (if applicable): [PrimeKB/Meridian](https://github.com/qmk/qmk_firmware/tree/master/keyboards/primekb/meridian) (revision master) - Operating system: `macOS Mojave (v10.14.6)` - AVR GCC version: `avr-gcc (Homebrew AVR GCC 8.4.0) 8.4.0` - ARM GCC version: `arm-none-eabi-gcc (GNU Tools for Arm Embedded Processors 8-2019-q3-update) 8.3.1 20190703 (release) [gcc-8-branch revision 273027]` - QMK Firmware version: `0.11.56` - Any keyboard related software installed? - [ ] AutoHotKey - [x ] Karabiner - [ ] Other: ## Additional Context - `git-bitsect` points to this commit to be the source of the problem: https://github.com/qmk/qmk_firmware/commit/c66df1664497546f32662409778731143e45a552.

Repository-Metriken

Stars: (20.368 Stars)
PR-Merge-Metriken: (Durchschn. Merge 20T 9h) (27 gemergte PRs in 30 T)

Beschreibung

Meridian's LED indicator lights won't turn off. Further more, it seems like rgblight_setrgb_at can no longer control the LEDs, which was previously working in the initial commit.

Describe the Bug

It seems like rgblight_setrgb_at no longer works properly for the Meridian firmwares (both VIA & default) on master. I'm not sure what could have caused it or if other STM32 related PCBs have the same issue. After git-bitsecting, I have narrowed it down to this commit to be the source of the problem.

System Information

Keyboard:
- Revision (if applicable): PrimeKB/Meridian (revision master)
Operating system: macOS Mojave (v10.14.6)
AVR GCC version: avr-gcc (Homebrew AVR GCC 8.4.0) 8.4.0
ARM GCC version: arm-none-eabi-gcc (GNU Tools for Arm Embedded Processors 8-2019-q3-update) 8.3.1 20190703 (release) [gcc-8-branch revision 273027]
QMK Firmware version: 0.11.56
Any keyboard related software installed?
- AutoHotKey
- [x ] Karabiner
- Other:

Additional Context

git-bitsect points to this commit to be the source of the problem: https://github.com/qmk/qmk_firmware/commit/c66df1664497546f32662409778731143e45a552.

Contributor Guide

Research-Richtung: Untersuchen Sie den Commit c66df1664497546f32662409778731143e45a552, um zu sehen, welche Änderungen rgblight setrgb at auf STM32 basierten Tastaturen wie der Meridian beeinflusst haben. Verfolgen Sie den LED Indikator Codepfad und testen Sie mit einem Debug Build auf ähnlicher Hardware.
Tech Stack: c
Domain: embedded iot
Issue Type: Fehler
Schwierigkeit: 3
Geschätzte Zeit: Halber Tag
Aktivitätsstatus: Aktiv
Klarheit: Meist klar
Voraussetzungen: GitCQMK basics
Einsteigerfreundlichkeit: 50