pyjanitor-devs/pyjanitor

[ENH] add_column fix

Open

#408 geöffnet am 13. Juli 2019

Auf GitHub ansehen
 (3 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Python (164 Forks)batch import
enhancementgood first issuegood intermediate issue

Repository-Metriken

Stars
 (1.217 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 2T 12h) (4 gemergte PRs in 30 T)

Beschreibung

Currently, the add_column function contains the parameter fill_remaining. I believe this parameter could be combined with the value parameter, such that when a list or tuple is inputted into value, it should automatically repeat to fill up the remainder of the column rather than having to specify that in another parameter (fill_remaining). (Also, whenever a list/tuple of a different size from the number of rows is inputted anyway, there is an error. So in my opinion, it would be more efficient to just automatically have the list/tuple iterate until it fills up the remainder of the column solely through inputting the list/tuple into the values parameter rather than also having the fill_remaining parameter.)

is also due to inputting a tuple/list of a different size than the column size will lead to an error anyway)

Relevant Context

Contributor Guide