palantir/blueprint

Using EditableText in selected tree element leads to unreadable text

Open

#2.236 geöffnet am 14. März 2018

Auf GitHub ansehen
 (3 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)TypeScript (20.263 Stars) (2.167 Forks)batch import
Package: coreType: bughelp wanted

Beschreibung

Bug report

  • Package version(s):
    "@blueprintjs/core": "^2.0.0-rc.2",
    "@blueprintjs/icons": "^2.0.0-rc.2",
    "@blueprintjs/table": "^2.0.0-rc.2",
  • Browser and OS versions: Chrome 64.0.3282.186 on OS X

Steps to reproduce

  1. Create
  2. Add child element with EditableText as label
  3. Select element and start editing

Actual behavior

The editable text is unreadable because it's white text on white background.

style-problem

Expected behavior

Visibly different colors for text and background.

Shouldn't pt.editable-text.pt-editable-editing set the text-color when setting the background-color? Setting only one of them sounds like inviting this kind of problems.

Contributor Guide

Tech Stack
typescriptreactcss
Domain
frontend
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
2
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
under 1 hour
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
CSSReact
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
80
Research-Richtung
Investigate the CSS for the Tree component's selected state. The issue describes that when using EditableText as a label in a selected tree element, the text becomes unreadable due to white text on white background. Look at the CSS selector `.pt editable text.pt editable editing` and ensure that both `color` and `background color` are set appropriately. The fix likely involves adding a specific color override for the editing state within the selected tree element. Check the relevant SCSS files in the Blueprint codebase, such as those for Tree and EditableText components.