[BUG] Unused search operations in the nyc_taxis workload
#67 geöffnet am 21.03.2023
Repository-Metriken
- Stars
- (33 Sterne)
- PR-Merge-Metriken
- (Durchschn. Merge 5T 19h) (2 gemergte PRs in 30 T)
Beschreibung
What is the bug?
The 'nyc_taxis' workload contains the following search operations (defined here).
- default
- range
- distance_amount_agg
- autohisto_agg
- date_histogram_agg
- date_histogram_calendar_interval
- date_histogram_calendar_interval_with_tz
- date_histogram_fixed_interval
- date_histogram_fixed_interval_with_tz
- date_histogram_fixed_interval_with_metrics
- auto_date_histogram
- auto_date_histogram_with_tz
- auto_date_histogram_with_metrics
Out of these, only 1–5 are being used in a test-procedure (append-no-conflicts) while they remaining are not mapped to any test-procedure (defined here). This reduces our coverage for 'aggregation' queries.
It appears that the 'date-histogram' test-procedure that executed these unmapped operations was incorrectly removed in https://github.com/opensearch-project/opensearch-benchmark-workloads/commit/cba4e45dda37ac03abbd3c9dd4532475dac355e9, thinking it was part of X-pack code, which it wasn't.
What is the expected behavior?
The missing test-procedure should be added back. I have confirmed that these operations execute successfully on open-source OpenSearch.
What is your host/environment?
Ubuntu 22.04.2 LTS (GNU/Linux 5.15.0-1031-aws x86_64) opensearch-benchmark 0.2.0