opensearch-project/OpenSearch

[Feature Request] Upgrade google-cloud-storage to v2

Open

#16.156 geöffnet am 1. Okt. 2024

Auf GitHub ansehen
 (4 Kommentare) (2 Reaktionen) (1 zugewiesene Person)Java (1.505 Forks)batch import
Pluginsenhancementgood first issue

Repository-Metriken

Stars
 (8.123 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 5T 9h) (266 gemergte PRs in 30 T)

Beschreibung

Is your feature request related to a problem? Please describe

Coming from conversation on https://github.com/opensearch-project/OpenSearch/pull/16072

The repository-gcs plugin currently depends on v1 of the google-cloud-storage dependencies. Dependabot has been creating automatic updates which consistently fail precommit and tests and cannot be merged without further modifications.

I have tried to upgrade this dependency, but consistently receive errors on GoogleCloudStorageBlobContainerRetriesTests.testWriteLargeBlob post-upgrade which uses the resumable upload feature of google cloud storage.

The test can be run using ./gradlew :plugins:repository-gcs:test --tests GoogleCloudStorageBlobContainerRetriesTests.testWriteLargeBlob -i. When running that test, I have to add an image: tag to test/fixtures/gcs-fixture/docker-compose.yml in all services in order to bring up the containers successfully.

Describe the solution you'd like

Update to v2 for com.google.cloud:google-cloud-storage dependency.

Related component

Plugins

Describe alternatives you've considered

No response

Additional context

There were lines added to dependabot.yml to prevent dependabot from making PRs on a major version update for this dependency. After upgrading to v2, make sure to remove these lines from dependabot.yml.

Contributor Guide