onivim/oni

Error Handling: Startup

Open

#1.383 geöffnet am 28. Jan. 2018

Auf GitHub ansehen
 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)TypeScript (336 Forks)batch import
enhancementhelp wantedinsider

Repository-Metriken

Stars
 (11.389 Stars)
PR-Merge-Metriken
 (Keine gemergten PRs in 30 T)

Beschreibung

This is tracking adding some better error-handling in startup, to give the user feedback when there is an issue on startup. Coming from @Akin909 's comments in #1381:

A solution to this is that the changeDir function should always check that the directory it is passed is valid before attempting to switch to it. A more general issue is that I think every function or rather main startup process should have a try/catch or some form of error handling so that oni doesn't end up hanging without any feedback given back to the user

We should do the following:

  • Wrap our 'start' call in a try/catch so that we can get errors
  • Have some UI affordance for showing an error UI (perhaps in Shell?). This could show any errors logged, as well as give the option for opening up a debug window. We could also potentially show an error notification once #1358 is in.

Contributor Guide