notable/notable

Delete button deletes non selected note

Open

#633 geöffnet am 30. Apr. 2019

Auf GitHub ansehen
 (6 Kommentare) (1 Reaktion) (0 zugewiesene Personen)TypeScript (21.204 Stars) (1.086 Forks)batch import
bugcan't reproducehelp wantedneeds more info

Beschreibung

  • OS: Windows 10:
  • Notable Version: 1.4.0:

Current behavior

Unfortunately I'm not able to reproduce the issue. What I did was:

  1. select a notebook Notebooks/work
  2. create select an existing note called Notes
  3. create a new note
  4. add a tag to the new note called Notebooks/Notebooks

Then I'm not entirely sure anymore what L did, I think I selected the new tag Notebooks/Notebooks and then deleted it. The selection went back to the previously selected Notebooks/work tag and the new untitled note was still open and in edit mode.

  1. press the delete button
  2. instead of the currently visible untitled note, the Notes note was deleted.
  3. after pressing the delete button again, the untitled note was deleted as well
  4. in the Trash were 2 notes. Both called untitled with the content of the newly created, untitled note. (it is possible that one of them was there before..)

might be related to #603

Expected behavior

the selected note gets deleted

Contributor Guide

Tech Stack
typescriptelectronreact
Domain
desktop
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-2 days
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
unclear
Voraussetzungen
JavaScriptTypeScriptElectron basics
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
20
Research-Richtung
Investigate the delete note functionality and how the selected note is tracked. Look at the note selection state management, especially after deleting a tag. Check the event handlers for the delete button and any asynchronous operations that might cause a mismatch between the displayed note and the deleted note. Examine files in src/renderer related to note operations and state.