First parameter to `add_cfe_tables` should be app name
#148 geöffnet am 17.05.2021
Repository-Metriken
- Stars
- (64 Sterne)
- PR-Merge-Metriken
- (PR-Metriken ausstehend)
Beschreibung
Describe the bug
The add_cfe_tables function is declared as follows in arch_build.cmake:
function(add_cfe_tables APP_NAME TBL_SRC_FILES)
The first parameter was intended to be the application name that the table is associated with, but historically any string was accepted since the string just served to make a unique target name.
To Reproduce
Sample_app always passes the string sampleAppTable here.
Expected behavior
Should pass sample_app as first argument.
Code snips https://github.com/nasa/sample_app/blob/1c32ed48ca358a3fdd55f1bdc9ae0dda61a4f4f7/CMakeLists.txt#L14
System observed on: Ubuntu
Additional context No major issue with the current build system, but will may become an issue if/when nasa/cfe#1538 is implemented, and may also become an issue if directory-scope include directories are removed.
Reporter Info Joseph Hickey, Vantage Systems, Inc.