mxstbr/sharingbuttons.io

Facebook Link is 301 re-directing

Open

#87 geöffnet am 4. Dez. 2017

Auf GitHub ansehen
 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (101 Forks)github user discovery
enhancementhelp wanted

Repository-Metriken

Stars
 (2.451 Stars)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

This may affect SEO of sites since 301 re-direct could be considered an error or bad site design: <!-- Sharingbutton Facebook --> <a class="resp-sharing-button__link" href="https://facebook.com/sharer/sharer.php?u=[URLHERE]">

Should have www in front of it except in lowercase as below:

<!-- Sharingbutton Facebook --> <a class="resp-sharing-button__link" href="https://WWW.facebook.com/sharer/sharer.php?u=[URLHERE]">

Small change but it gets picked up by seo tools,

Also still have the issue I mentioned before about Pinterest requiring a "media file" which links to an image, would be nice to ask us what image to link to instead of just creating a broken Pinterest link.

Thanks! I will try to do pull request later but I'm not sure if I can as it would be my first. Daniel

Contributor Guide