mozilla/mozci-tools
Auf GitHub ansehenrefactor `dump_failures` script to have an excluded manifest list instead of harcoded in the middle of the logic
Open
#9 geöffnet am 29. Sept. 2021
good first issue
Repository-Metriken
- Stars
- (7 Stars)
- PR-Merge-Metriken
- (PR-Metriken ausstehend)
Beschreibung
in dump_failures.py, there is some code like this:
if manifest in ("dom/canvas/test/mochitest.ini",):
continue
the reason for this is the format of test names and output is not supported yet (due to being a sub test suite) in dump_failures, so until we have logic to handle these sub test suites it is simpler to skip these as seen in the current code.
To solve this issue here are some recommendations:
- build a list of manifests that are defined at the top of the file in a constant (SKIPPED_MANIFESTS = ...)
- replace the current code to use the new list of defined tests
- add a comment in code to help out with this, update any documentation as needed