mimblewimble/grin

Re-introduce integration tests for the node

Open

#2.957 geöffnet am 22. Juli 2019

Auf GitHub ansehen
 (2 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Rust (991 Forks)batch import
enhancementgood first issuehelp wanted

Repository-Metriken

Stars
 (4.876 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 6T 11h) (25 gemergte PRs in 30 T)

Beschreibung

In the past the node and the wallet were in the same repo. When the wallet was extracted into a separate repo, integration tests were moved to - https://github.com/mimblewimble/grin-wallet/tree/master/integration It would be beneficial to provide a simple way to run integration suits as part of node tests too. There are several possible options (there are some other for sure):

  • Move part of the tests to grin repo. Many tests requires wallet functionality too, we could move only tests which don't require wallet, but it doesn't sound great. We could create some mock wallet, not sure if this effort is justified.
  • Extract test into another repo and add to grin and grin-wallet as submodule. The issue is how to make cargo happy in this case and how to specify grin-wallet dependency in grin and vice versa.
  • Don't touch anything and always run wallet test with local version of grin repo. It adds some time to CI build and UX is poor.

Contributor Guide