microsoft/terminal

Refactor IconPathConverter::IconWUX() to not set icon size

Open

#19.806 geöffnet am 28. Jan. 2026

Auf GitHub ansehen
 (3 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)C++ (103.173 Stars) (9.275 Forks)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Terminal

Beschreibung

I hit this problem pretty regularly whenever I'm working with icons (especially in the settings UI).

IconPathConverter::IconWUX() is a really powerful function that we use throughout the codebase to convert an icon path/code into an actual icon UI. However, we explicitly set the size of the icon on the way out. This was great when it was introduced because it meant that the icons in the dropdown, tabs, etc. all had the correct size. But as the project has grown to use those icons elsewhere (namely in the Settings UI), this has become a huge pain. Icons aren't always drawn to be the same size, especially if they're coming from different sources (i.e. hardcoded font icon vs evaluated icon in profile).

I'd update it whenever I hit the problem, but it's realistically a fundamental enough change that it will have side effects. I'd rather have it be its own change and audit the app to make sure it doesn't break anything.

References

Contributor Guide

Tech Stack
cpp
Domain
desktop
Issue Type
refactor
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
3-5 days
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
fresh
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Familiarity with C++Understanding of Windows Terminal settings UI
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
50
Research-Richtung
Start by examining the IconPathConverter::IconWUX() function in the referenced file (src/cascadia/UIHelpers/IconPathConverter.cpp line 318). Understand how it currently sets icon size and how it is called throughout the codebase, particularly in the settings editor (src/cascadia/TerminalSettingsEditor). Then, after removing the size setting, test all icon usages to ensure they render correctly without explicit sizing, and adjust any callers that rely on the old behavior.