Missing operator delete/delete[] for some allocated objects · microsoft/Terminal#875

(7 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)C++ (3.212 Forks)batch import

Area-CodeHealthHelp WantedIssue-BugProduct-Conhost

Repository-Metriken

Stars: (35.764 Stars)
PR-Merge-Metriken: (Durchschn. Merge 27T 19h) (24 gemergte PRs in 30 T)

Beschreibung

Hi.

Looks like there are few places in the Terminal code where I can suspect a memory leaks due to missing operator delete or operator delete[]. These allocation sites can be grouped into following:

raw operator new without operator delete like this https://github.com/Microsoft/Terminal/blob/master/src/cascadia/TerminalConnection/ConptyConnection.cpp#L191
allocation by operator new some global object or class member (https://github.com/Microsoft/Terminal/blob/master/src/cascadia/TerminalControl/TermControl.cpp#L281)
allocation by operator new some memory in a function and return it by raw pointer, which can leak then.

Here is my gist with quite a simple grep foroperator new calls - https://gist.github.com/dreamer-dead/c43248466fc4d445378b4dfba80d8d25

Is this an intentional behaviour or a bug that should be fixed?

Contributor Guide

Research-Richtung: Untersuche jede Allokationsstelle, die im Gist aufgeführt ist (z.B. ConptyConnection.cpp Zeile 191, TermControl.cpp Zeile 281), und füge fehlende operator delete/delete[] Aufrufe hinzu. Ziehe die Verwendung von RAII oder Smart Pointern in Betracht, um Speicherlecks zu vermeiden.
Tech Stack: cpp
Domain: backend
Issue Type: Fehler
Schwierigkeit: 3
Geschätzte Zeit: 1-3 Stunden
Aktivitätsstatus: Aktiv
Klarheit: Klar
Voraussetzungen: C++Memory Management
Einsteigerfreundlichkeit: 65

Repository-Metriken

Beschreibung

Contributor Guide

Erhalte frische Easy Issues per E-Mail.