microsoft/Terminal

Memory leak and other issues when saving settings

Open

#10.609 geöffnet am 11. Juli 2021

Auf GitHub ansehen
 (9 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)C++ (3.212 Forks)batch import
Area-SettingsUIExternal-Blocked-WinUI3Help WantedIssue-BugPriority-1Product-Terminal

Repository-Metriken

Stars
 (35.764 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 27T 19h) (24 gemergte PRs in 30 T)

Beschreibung

Windows Terminal version (or Windows build number)

1.8.1521.0 (also observed on source build 2021-07-11)

Other Software

No response

Steps to reproduce

Open the settings dialog and spam click save. No option needs to be changed.

Video: 13 seconds in, the settings could not be reloaded from file (not sure if it is not loading or file corruption). https://user-images.githubusercontent.com/2277504/125179830-a31f3a00-e1f2-11eb-8b6f-6f6aa07896c5.mp4

Expected Behavior

Memory stays roughly the same, settings file can be loaded after saving, main UI does not extend past its borders.

Actual Behavior

Memory grows and is not reclaimed, settings file can sometimes not be loaded after saving, UI grows past its borders during reloading.

(Second and third only discovered after deciding to record a video for the memory leak)

Not sure if you want separate tracking issues for these, let me know.

Contributor Guide