meshery/meshery

[UI] ConfirmationModal.tsx disables all TypeScript checks via @ts-nocheck

Open

#18.405 geöffnet am 2. Apr. 2026

Auf GitHub ansehen
 (8 Kommentare) (0 Reaktionen) (1 zugewiesene Person)HTML (10.013 Stars) (3.101 Forks)batch import
component/uiframework/reactgood first issueissue/validkind/buglanguage/javascript

Beschreibung

Description

ui/components/ConfirmationModal.tsx has // @ts-nocheck at the top of the file, which disables all TypeScript type checking for the entire component.

File: ui/components/ConfirmationModal.tsx:1

// @ts-nocheck

Why This Is a Problem

@ts-nocheck suppresses all TypeScript errors in the file, defeating the purpose of using TypeScript. This means:

  1. Type errors in this component pass silently and are only discovered at runtime
  2. Incorrect prop types won't be caught during development
  3. Refactors that change interfaces won't produce errors in this file
  4. Code review cannot rely on TypeScript to catch regressions here

ConfirmationModal is used throughout the application as a shared component, making silent type errors here high-impact.

Expected Behavior

The @ts-nocheck directive should be removed and any underlying type errors should be properly resolved with correct TypeScript types.

Steps to Reproduce

  1. Open ui/components/ConfirmationModal.tsx
  2. Observe line 1: // @ts-nocheck

Suggested Fix

Remove // @ts-nocheck, address any TypeScript errors that surface, and add proper type annotations for props and state.

Contributor Guide

Tech Stack
typescriptreact
Domain
frontend
Issue Type
refactor
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
blocked
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
TypeScriptReact
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
65
Research-Richtung
Open the file `ui/components/ConfirmationModal.tsx`. Remove the `// @ts nocheck` comment on line 1. Run the TypeScript compiler to identify any type errors that arise. Fix each error by adding proper type annotations for props, state, and function signatures. Ensure the component still renders correctly by running the existing tests.