meliorence/react-native-snap-carousel

Swipes do not register in top half of portrait-oriented Carousel Card ('stack', and 'tinder')

Open

#262 geöffnet am 8. Feb. 2018

Auf GitHub ansehen
 (19 Kommentare) (10 Reaktionen) (0 zugewiesene Personen)JavaScript (10.045 Stars) (2.223 Forks)batch import
bughelp wanted

Beschreibung

@bd-arc,

Didn't follow the Template this time around due to time constraints, but I want to put this potential issue on your radar. It's a really weird one..

To reproduce:

  • I set up a Carousel with tall (portrait-oriented) cards.
  • I found that once the card exceeded a rectangular shape, the hitbox for swipes diminished.
  • Did not do much else by way of customization. Occurs with layouts 'stack', and 'tinder'

Works:

Seeing Issue:

Thanks for taking a look.

Reproduced on iOS device / simulator. Tested in Dev mode.

Contributor Guide

Tech Stack
javascriptreact
Domain
mobile
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
half day
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
mostly clear
Voraussetzungen
React Native basicsgesture handling
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
35
Research-Richtung
The issue is a bug where swipes do not register in the top half of portrait oriented carousel cards for 'stack' and 'tinder' layouts. To reproduce, set up a carousel with tall cards and attempt to swipe; the hitbox appears diminished. Investigation should focus on the gesture handling code in the Carousel component, particularly the onPanResponder or onLayout methods that determine touch area. Check if the layout calculations for portrait cards have any clipping or offset issues. Also review comments on the issue for any suggested fixes or files involved, such as the CardStack or Tinder layout components.