luckyframework/avram
Sub-associations from polymorphic types don't work
Offen
#1.036 geöffnet am 08.05.2024
bughacktoberfest
Repository-Metriken
- Stars
- (180 Sterne)
- PR-Merge-Metriken
- (PR-Metriken ausstehend)
Beschreibung
It appears we never actually test using polymorphic associations. If you try and call a method on them, you'll get a compile time error because Crystal can't determine the true shape of the object.
table do
belongs_to user : User
belongs_to car : Car?
belongs_to computer : Computer?
polymorphic purchasable, associations: [:car, :computer]
end
purchase = PurchaseQuery.new.preload_purchasable.user_id(current_user.id).first
# We currently test that this works, and it does...
purchase.purchasable
# This however does not work
purchase.purchasable.owner!
# => Error: undefined method 'owner!' for User (compile-time type is BaseModel+)
In order to do this, you have to cast it to the proper type. purchase.purchasable.as(Car).owner!, but the whole point of the polymorphic association is that it could be any number of types so that gets a bit tricky