llvm/llvm-project

Failure to recognise unnecessary sext for add+cmp

Open

#130.088 geöffnet am 6. März 2025

Auf GitHub ansehen
 (23 Kommentare) (0 Reaktionen) (1 zugewiesene Person)C++ (10.782 Forks)batch import
good first issuellvm:instcombinemissed-optimization

Repository-Metriken

Stars
 (26.378 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 1T 2h) (1.000 gemergte PRs in 30 T)

Beschreibung

Pulled out #76524 - we fail to recognize that extension is unnecessary and that the trunc is nsw

define i8 @src(i16 noundef %x) {
entry:
  %conv = sext i16 noundef %x to i128
  %add = add i128 %conv, 128
  %or.cond.i = icmp ult i128 %add, 256
  assume i1 %or.cond.i
  %conv1 = trunc i16 noundef %x to i8
  ret i8 %conv1
}
=>
define i8 @tgt(i16 noundef %x) {
entry:
  %add = add i16 noundef %x, 128
  %or.cond.i = icmp ult i16 %add, 256
  assume i1 %or.cond.i
  %conv1 = trunc nsw i16 noundef %x to i8
  ret i8 %conv1
}
Transformation seems to be correct!

https://alive2.llvm.org/ce/z/epn8hd

Contributor Guide