linebender/parley

Add the linebender lint set

Open

#108 geöffnet am 25. Aug. 2024

Auf GitHub ansehen
 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)Rust (92 Forks)github user discovery
good first issue

Repository-Metriken

Stars
 (620 Stars)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

We should add a standardized set of rustc lints and clippy lints to all our projects. If we raise MSRV to 1.74, we can add them directly to Cargo.toml.

See zulip discussion for what our lint set should be. See https://github.com/linebender/peniko/pull/47/ for our current lint set.

Aside from the Cargo.toml lints, we should also add the following annotation to our crate root:

#![warn(clippy::print_stdout, clippy::print_stderr, clippy::dbg_macro)]

(We don't want a workspace-level lints for those because we want to tolerate prints in tests and examples.)

See this zulip thread for details.

We should add the following annotation at the crate roots:

We should also remove leftover prints, if any, or give them an opt-out.

Contributor Guide