kubernetes/kubernetes

rewrite TestUnderTemporaryNetworkFailure to use nftables

Open

#119.047 geöffnet am 3. Juli 2023

Auf GitHub ansehen
 (18 Kommentare) (1 Reaktion) (3 zugewiesene Personen)Go (43.066 Forks)batch import
help wantedsig/networktriage/accepted

Repository-Metriken

Stars
 (122.268 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 28T 17h) (343 gemergte PRs in 30 T)

Beschreibung

Some e2e tests use TestUnderTemporaryNetworkFailure in test/e2e/framework/network to test how a component behaves when the network goes down. (Additionally, one test in test/e2e/apimachinery does the same thing "by hand" but ought to be rewritten to use TestUnderTemporaryNetworkFailure, or at least to use the BlockNetwork / UnblockNetwork functions that it uses.)

This test currently uses iptables rules to simulate the network failure, but in the future, nftables will be more widely-supported/widely-available than iptables, so it should be rewritten to try using nft first, and only fall back to iptables if nft isn't installed.

/sig network

[EDIT: TestUnderTemporaryNetworkFailure was removed as part of #128896, so now this is just about the etcd test.]

Contributor Guide