help wantedkind/api-changepriority/important-soontriage/accepted
Repository-Metriken
- Stars
- (4.267 Sterne)
- PR-Merge-Metriken
- (PR-Metriken ausstehend)
Beschreibung
As part of #11733, we have configured KAL, that kube-api-linter to run against the APIs within this repository.
There are a number of linter rules that need to be reviewed and enabled 1 by 1.
This issue is to track the implementation of enabling each of these linters
TODO
- conditions - #11847
- commentstart -
- #11870
- Related: https://github.com/kubernetes-sigs/cluster-api/issues/11238
- integers - #11887
- jsontags - #11890
- maxlength -
- Enable the linter #11906
- Enable MaxItems https://github.com/kubernetes-sigs/cluster-api/pull/11934
- Enable MaxLength https://github.com/kubernetes-sigs/cluster-api/pull/11949
- nobools - #11911
- nofloats - #11910
- optionalorrequired
- Enable the linter #11909
- Follow-up for Items fields (exclude "field Items must be marked as optional or required")
- requiredfields - #11908
- statussubresource - #11907
Not doing
NoPhase
Per discussion in July 2024, we are keeping phase fields for now. See https://github.com/kubernetes-sigs/cluster-api/pull/10897#discussion_r1685929508 and https://github.com/kubernetes-sigs/cluster-api/pull/10897#discussion_r1685919394 for the context on why we are still keeping phases.