KCP: Consider reconciling on Pod events · kubernetes-sigs/cluster-api

(10 Kommentare) (0 Reaktionen) (1 zugewiesene Person)Go (1.532 Forks)auto 404

help wantedkind/featurepriority/important-longtermtriage/accepted

Repository-Metriken

Stars: (4.267 Sterne)
PR-Merge-Metriken: (PR-Metriken ausstehend)

Beschreibung

We recently changed KCP to use a cached client to retrieve the Pods we care about.

This means we already have informers for Pods of workload clusters.

I'm wondering if we should also trigger reconciles if these Pods change (similar to how we watch on Node events in the Machine controller).

Pro

we can instantly react to Pod changes instead of using requeue after

Con

we get probably more reconciles
- This can be mitigated by only letting the update events through that we care about or by rate-limiting. This might even lead to less reconciles when we get rid of the requeues we have because we don't watch on Pod events (https://github.com/kubernetes-sigs/cluster-api/blob/d9341254c25ca578f9c82d5cf69f58c1ffc59a9b/controlplane/kubeadm/internal/controllers/controller.go#L253)

Contributor Guide

Research-Richtung: Untersuchen Sie, wie die Pod Ereignisabstimmung zum KCP Controller hinzugefügt werden kann, unter Berücksichtigung von Informern und Ratenbegrenzungsstrategien.
Tech Stack: go
Domain: backendapi
Issue Type: Funktion
Schwierigkeit: 3
Geschätzte Zeit: Halber Tag
Aktivitätsstatus: Aktiv
Klarheit: Klar
Voraussetzungen: GoKubernetesKCP
Einsteigerfreundlichkeit: 40