keystonejs/keystone-classic

Front Page Icon Missing in Mobile Navigation in Admin UI

Open

#4.603 geöffnet am 24. März 2018

Auf GitHub ansehen
 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (14.656 Stars) (2.288 Forks)batch import
4.x candidatebughelp wanted

Beschreibung

At the right hand side of Admin UI Navigation Bar, there are 2 buttons - one for going to main page (Globe Icon) and one for sign out. This is ok with Primary View. However, when viewed in Mobile, the main page icon will be missing.

Searched inside github and found the octicon only present in Navigation/Primary view, but not mentioned in Navigation/Mobile view.

https://github.com/keystonejs/keystone/search?utf8=%E2%9C%93&q=octicon-globe&type=

Kindly see if this is by design but currently seems I have no way to switch from Admin UI to main page in mobile devices. Thanks.

Software Version
Keystone 4.0.0-beta.5
Node v8.10.0

Contributor Guide

Tech Stack
javascriptnodejs
Domain
frontend
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
2
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
under 1 hour
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Basic knowledge of ReactFamiliarity with Keystone's Admin UI navigation
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
70
Research-Richtung
The issue reports that the globe icon for returning to the main page is missing in the mobile navigation bar. The fix likely involves adding the octicon globe component to the mobile navigation view, similar to how it's included in the primary view. Investigate the Admin UI's navigation components in the keystone classic repository, specifically files under `admin/ui/` or `public/` related to navigation. The search for 'octicon globe' shows it's present in primary navigation but absent in mobile, so locate the mobile navigation partial and add the icon.