keycloak/keycloak

No information in log by subject confirmation validation after commit f0381f8482272698264d8951705f61c5f9c09fba

Open

#48.417 geöffnet am 23. Apr. 2026

Auf GitHub ansehen
 (2 Kommentare) (1 Reaktion) (0 zugewiesene Personen)Java (8.346 Forks)batch import
area/samlhelp wantedkind/bugpriority/normalstatus/auto-bumpstatus/auto-expireteam/core-protocols

Repository-Metriken

Stars
 (34.398 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 6T 19h) (384 gemergte PRs in 30 T)

Beschreibung

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

saml

Describe the bug

Neither log entry nor event reason by the validation after the commit https://github.com/keycloak/keycloak/commit/f0381f8482272698264d8951705f61c5f9c09fba#diff-372f29884b6defbcc22974ca30286c5bc06a7257600f7a9b7b5e44441520dcd8L594 Code is

                if (!validateInResponseToAttribute(responseType, expectedRequestId)
                        || !validateSubjectConfirmationData(responseType, expectedRequestId)) {
                    event.event(EventType.IDENTITY_PROVIDER_RESPONSE);
                    event.error(Errors.INVALID_SAML_RESPONSE);
                    return ErrorPage.error(session, authSession, Response.Status.BAD_REQUEST, Messages.INVALID_REQUESTER);
                }

Version

26.5.6

Regression

  • The issue is a regression

Expected behavior

SubjectConfirmationDataValidator should log errors not in log level trace or SAMLEndpoint should log error like here (https://github.com/keycloak/keycloak/commit/f0381f8482272698264d8951705f61c5f9c09fba#diff-372f29884b6defbcc22974ca30286c5bc06a7257600f7a9b7b5e44441520dcd8L578) logger.errorf("Response Issuer validation failed: expected %s, actual %s", config.getIdpEntityId(), responseIssuer);

Actual behavior

Neither log entry nor event reason if SAMLEndpoint.validateSubjectConfirmationData() fails

How to Reproduce?

It is hard to reproduce but try to send SAML response from brokered SAML IDP with invalid subject confirmation like

<saml:Assertion ...>
        ...
	<saml:Subject>
		<saml:SubjectConfirmation ...>
			<saml:SubjectConfirmationData ... Recipient="wrong URL here" ..."/>
		</saml:SubjectConfirmation>
	</saml:Subject>

Anything else?

No response

Contributor Guide