kantord/SeaGOAT

Support Mac OS. Help wanted 🙏🍎

Offen

#178 geöffnet am 07.09.2023

 (9 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Python (91 Forks)github user discovery
help wantedup for grabs

Repository-Metriken

Stars
 (1.302 Sterne)
PR-Merge-Metriken
 (Keine gemergten PRs in 30 T)

Beschreibung

At all steps, SeaGOAT is developed with guaranteeing Mac OS support. That being said, as I don't have a Mac OS device and I don't have expertise regarding Mac OS development workflows, I have not been able to verify that it works properly.

Help wanted!

Here is a rough checklist of the current status of Mac OS support:

  • Enable CI checks for Mac OS
  • Make sure that all CI tests pass for Mac
  • Manually test SeaGOAT on Mac
  • Document installation steps on Mac
  • Make sure that any required Mac-specific features are implemented
  • Make sure that it's easy to install on Mac using common tools (homebrew?)

Currently the main problem is that I have not been able to try and run SeaGOAT manually on OSX.

Also I have discovered that some of the tests are failing, so I created a CI file specifically for OSX that only checks some of the tests are are passing without issue:

https://github.com/kantord/SeaGOAT/blob/1edae8e4b9272906300046cf99bb5de8fd4256aa/.github/workflows/test-mac-os.yml#L56-L58

For comparison the Linux tests look like this:

https://github.com/kantord/SeaGOAT/blob/1edae8e4b9272906300046cf99bb5de8fd4256aa/.github/workflows/test.yml#L56-L58

Contributor Guide