[Refactor]: [ACI] reuse utility functions from connector utils · juspay/hyperswitch#7927

2025-04-29T08:56:26.000Z

### Refactor Description - In Hyperswitch, reusable and connector-agnostic functions used in connector integrations are added to crates/hyperswitch_connectors/src/utils.rs. However, parts of the current ACI integration reimplement these functions instead of reusing them. ### Possible Implementation 1. Review transformer.rs in the ACI connector to identify opportunities to reuse functions from `crates/hyperswitch_connectors/src/utils.rs` . 2. Replace the existing implementations with the corresponding reusable functions from the utils module where applicable. ### Example Current - `shopper_result_url: item.router_data.request.router_return_url.clone(),` Expected - `shopper_result_url: item.router_data.request.get_router_return_url().ok(),` ### Have you spent some time checking if this feature request has been raised before? - [ ] I checked and didn't find a similar issue ### Have you read the Contributing Guidelines? - [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md) ### Are you willing to submit a PR? None

(3 Kommentare) (0 Reaktionen) (1 zugewiesene Person)Rust (4.676 Forks)batch import

A-connector-integrationC-refactorE-easygood first issue

Repository-Metriken

Stars: (42.690 Stars)
PR-Merge-Metriken: (Durchschn. Merge 8T 12h) (212 gemergte PRs in 30 T)

Beschreibung

Refactor Description

In Hyperswitch, reusable and connector-agnostic functions used in connector integrations are added to crates/hyperswitch_connectors/src/utils.rs.

However, parts of the current ACI integration reimplement these functions instead of reusing them.

Possible Implementation

Review transformer.rs in the ACI connector to identify opportunities to reuse functions from crates/hyperswitch_connectors/src/utils.rs .
Replace the existing implementations with the corresponding reusable functions from the utils module where applicable.

Example

Current - shopper_result_url: item.router_data.request.router_return_url.clone(), Expected - shopper_result_url: item.router_data.request.get_router_return_url().ok(),

Have you spent some time checking if this feature request has been raised before?

I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

I have read the Contributing Guidelines

Are you willing to submit a PR?

None

Contributor Guide

Research-Richtung: Überprüfen Sie die Datei transformer.rs des ACI Connectors im Hyperswitch Repository. Identifizieren Sie Stellen, an denen Hilfsfunktionen aus crates/hyperswitch connectors/src/utils.rs dupliziert sind oder vorhandenen Code ersetzen können, und ersetzen Sie sie entsprechend.
Tech Stack: rust
Domain: backendapipayments
Issue Type: Refactoring
Schwierigkeit: 3
Geschätzte Zeit: Halber Tag
Aktivitätsstatus: Aktiv
Klarheit: Klar
Voraussetzungen: RustFamiliarity with Hyperswitch codebaseUnderstanding of connector integration pattern
Einsteigerfreundlichkeit: 65