jsx-eslint/eslint-plugin-react
Should react/no-did-mount-set-state trigger on ES2017 async componentDidMount?
Offen
#1.110 geöffnet am 10.03.2017
bughelp wanted
Repository-Metriken
- Stars
- (9.293 Sterne)
- PR-Merge-Metriken
- (PR-Metriken ausstehend)
Beschreibung
The rule react/no-did-mount-set-state triggers error on async componentDidMount function for a deferred setState. Basically, this.setState() is being called here after an async operation has been completed. It is not re-rendering straight after mounting, but only after some data has been retrieved from a server. Does it make sense to error on this?
async componentDidMount() {
try {
await someAsyncOperation();
} catch (e) {
this.setState({errorMessage: 'Failed to load data!'});
}
}