josdejong/jsoneditor

Schema enum dropdown not supported by $ref files.

Open

#1.044 geöffnet am 10. Juli 2020

Auf GitHub ansehen
 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (2.034 Forks)batch import
featurehelp wanted

Repository-Metriken

Stars
 (10.781 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 15h 36m) (3 gemergte PRs in 30 T)

Beschreibung

Great library, big fan. Just dropping a quick note concerning the rendering of the dropdown menu for validation using the supplied JSON schema. I've got it happily working with programatic additions to the main JSON schema but have found a small discrepancy in how the render handles external $ref files. Pictures speak clearer so I'll demonstrate:

VLAN enum working fine when placed directly within the main schema object. (main object validates on test2 | test3)

VLAN enum in external object definitions, passed through schemaRefs. Can see it is still validating (external definitions.json set to test4 | test5 to distinguish), however no longer rendering a dropdown, which allows user to supply random input.

I'm luckily able to go about using monolithic JSON schemas if needed, so I can weigh my need of input restriction vs code reuse, but thought this would be good to point out, and would be great to get cleaned up and unified across behaviors. Cheers!

Contributor Guide