internetarchive/openlibrary

Edition's bookcover alt-text should pull author from work

Open

#486 geöffnet am 28. Apr. 2017

Auf GitHub ansehen
 (26 Kommentare) (0 Reaktionen) (1 zugewiesene Person)Python (4.626 Stars) (1.172 Forks)batch import
Affects: DataAffects: ServerAffects: UIGood First IssueLead: @cdriniNeeds: ResponsePriority: 3Type: Bug

Beschreibung

Correcting a work's author (e.g. https://openlibrary.org/works/OL3531880W/Living_with_Leviathan?b=4&a=3&_compare=Compare&m=diff ) also corrects the Alt-text for the work cover, (e.g. to alt="Cover of: Living with Leviathan by David Brian Smith" ) but fails to correct the Alt-text for the editions below it, instead leaving it untouched (e.g. as alt="Cover of: Living with Leviathan by David Buchanan Smith" ). Might this be why the edition is still found on searches for the old author spelling?

view-source:https://openlibrary.org/books/OL17631357M/Living_with_Leviathan shows the error at lines 349, 357, 371

Proposed fix: Ensure the edition alt-text author name uses the same source data as the rest of the edition interface, which takes the author attached to the work(if it exists)

Contributor Guide

Tech Stack
python
Domain
backendaccessibility
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Basic knowledge of PythonFamiliarity with OpenLibrary's data model (works vs editions)
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
60
Research-Richtung
Focus on the template or view that generates the HTML for edition book covers. Look in the OpenLibrary codebase for where 'alt' attribute of cover images is set, likely in a Python template file (e.g., .html or .pt). The issue notes that the alt text for editions does not update when the work's author is corrected, while the work cover does. Compare how the work cover gets its author data versus the edition cover. Ensure that the edition alt text uses the same author source as the rest of the edition interface, which should be the work's author if available.