google/comprehensive-rust

Rewrite speaker note system

Offen

#1.232 geöffnet am 22.09.2023

 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)Rust (2.009 Forks)batch import
good first issuehelp wanted

Repository-Metriken

Stars
 (32.954 Sterne)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

The speaker-notes.js file is a little home-grown system for injecting speaker notes to the pages.

I would like to rewrite this to use a more modern development style:

  • we should minimize the code when publishing the course
  • we should make the label ("Speaker Notes") translatable!
  • we could perhaps use a library for some of the state logic?
  • we could take advantage of https://github.com/google/mdbook-i18n-helpers/issues/70 when it's ready to do less on the fly DOM manipulation

Contributor Guide