google/closure-compiler

require with a substitution-free template string is not recognized by process_common_js_modules

Open

#2.626 geöffnet am 21. Aug. 2017

Auf GitHub ansehen
 (4 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Java (7.176 Stars) (1.197 Forks)batch import
P2help wanted

Beschreibung

I'm using the compiler with the process_common_js option set to true.

The following code works fine:

/** @const */
const update = require( "./update.js" );

However, switching to a substitution-free template string breaks:

/** @const */
const update = require( `./update.js` );

resulting in:

src/main.js:8: ERROR - variable require is undeclared
const update = require( `./update.js` );
               ^^^^^^^

The code style of the project I'm working on imposes template strings wherever syntactically possible (only object keys get a pass and can use double quotes). Of course, this does include paths in require statements. Sadly, it seems the CommonJS machinery does not recognize such statements as processable.

As a workaround, I can break from the code style but it is clearly not ideal and it would be really nice if the compiler was able to handle this.

Contributor Guide

Tech Stack
javajavascriptnodejs
Domain
tooling
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
JavaScriptCommonJS modulesGoogle Closure Compiler internals
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
60
Research-Richtung
Examine the source code of the Closure Compiler, particularly the function `process common js modules`. The issue is that template literals (backticks) without substitutions are not recognized as valid require() arguments. Look for where the compiler parses and extracts module paths from require statements; the fix likely involves updating a regex or parser to accept template strings. Check the issue comments for any additional context. The repository is at https://github.com/google/closure compiler.