[BUG] pkg-config file is broken when CMAKE_INSTALL_{INCLUDE,LIB}DIR is absolute

(1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)C++ (1.539 Forks)batch import

help wanted

Repository-Metriken

Describe the bug

As per title: cmake/benchmark.pc.in has

prefix=@CMAKE_INSTALL_PREFIX@
exec_prefix=${prefix}
libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@
includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@

and so can’t handle absolute paths in CMAKE_INSTALL_{INCLUDE,LIB}DIR. This leads to broken .pc files on NixOS in particular.

Identical to https://github.com/libjxl/libjxl/issues/1400 (fixed). See “Concatenating paths when building pkg-config files” for a thorough discussion of the problem and a suggested fix, or KDE’s extra-cmake-modules for a simpler approach.

System

$ uname -a
Linux localhost 5.15.36 #1-NixOS SMP Wed Apr 27 12:39:02 UTC 2022 x86_64 GNU/Linux

Research-Richtung: The bug is in the cmake/benchmark.pc.in file where libdir and includedir are always prefixed with prefix, even when they are absolute paths. The fix should check if the path is absolute before concatenating. Two approaches are referenced: using a helper function from cmake snips or the approach from KDE's extra cmake modules. The contributor should implement one of these and ensure the generated .pc file works correctly with absolute paths, such as on NixOS. No linked PRs or assignees.
Tech Stack: cpp
Domain: build system
Issue Type: Fehler
Schwierigkeit: 2
Geschätzte Zeit: 1-3 Stunden
Aktivitätsstatus: Veraltet
Klarheit: Klar
Voraussetzungen: Basic understanding of CMakeFamiliarity with pkg config file format
Einsteigerfreundlichkeit: 70