globalizejs/globalize

Tests: Dependencies

Open

#372 geöffnet am 19. Dez. 2014

Auf GitHub ansehen
 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (645 Forks)batch import
help wanted

Repository-Metriken

Stars
 (4.759 Stars)
PR-Merge-Metriken
 (Keine gemergten PRs in 30 T)

Beschreibung

On https://github.com/jquery/globalize/pull/370, we had missing dependencies. But, we were unable to figure that out by our current unit tests. They are indirect dependencies (i.e., "plugin dependencies") and another parallel unit test was loading them before they were being used. Therefore, no problem occurred until we started to test them on high latency envs like via browserstack-runner.

Ideally, each unit test should be executed using the dependencies it's explicitly requiring with no interference.

Contributor Guide