ggml-org/whisper.cpp

max-len as a range or 'suggestion' to reduce dangling tokens

Open

#543 geöffnet am 27. Feb. 2023

Auf GitHub ansehen
 (1 Kommentar) (2 Reaktionen) (0 zugewiesene Personen)C++ (49.693 Stars) (5.535 Forks)batch import
enhancementgood first issue

Beschreibung

suggestion that the max-len argument allow for some ambiguity of +- words/tokens or a nargs range instead of a hard int, so that the output files don't dangle a single word/token on successive timestamps.

Ex: Given the following output, it would probably be preferrable that the 2nd and 5th timestamp (there/job) would appear with the previous timestamp, possibly hard-wrapped to a second line in the cue, rather than alone.

` [00:06:23.160 --> 00:06:27.000] The other district where Pat was over

[00:06:27.000 --> 00:06:27.000] there,

[00:06:27.000 --> 00:06:28.380] also they know her.

[00:06:28.380 --> 00:06:31.680] So I think they were doing a very good

[00:06:31.680 --> 00:06:32.400] job.

[00:06:32.400 --> 00:06:35.750] - So only those two candidates were the

[00:06:35.750 --> 00:06:36.160] only ones `

Contributor Guide

Tech Stack
cpp
Domain
backendcli
Issue Type
feature
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
half day
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
mostly clear
Voraussetzungen
Familiarity with C++Understanding of whisper.cpp command line parsing
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
60
Research-Richtung
First, examine how the max len argument is currently parsed and applied in main.cpp. The issue suggests allowing a range or tolerance (e.g., an integer with a +/ value). Look at the argument parsing code, likely using argparse or similar. Then, modify the logic to accept a range and adjust the output formatting to avoid dangling single words. The comment in the issue provides example output showing the problem; use that to test the change.