getredash/redash

Can't delete a data source if one of the queries references query result from it but uses a different data source

Open

#3.843 geöffnet am 29. Mai 2019

Auf GitHub ansehen
 (6 Kommentare) (1 Reaktion) (1 zugewiesene Person)Python (24.845 Stars) (4.236 Forks)batch import
BackendBughelp wanted

Beschreibung

Issue Summary

When you have the following situation:

Query A references query result from data source A, but itself references data source B.

You will not be able to delete data source A, because it will fail to delete the query results using it.

Steps to Reproduce

The way the above can happen is if:

  1. You execute query A while it uses data source A and update it to use data source B.
  2. If the data source update happens right after this query was executed but before we actually update the query result reference.

It's an edge case, but happened already twice for people who reported it.

The correct solution here is to update the latest_query_data_id reference to get nullified if the query result is deleted.

Technical details:

  • Redash Version: 7

Contributor Guide

Tech Stack
python
Domain
backend
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
half day
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Python programmingSQLAlchemy ORMDatabase concepts
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
45
Research-Richtung
Examine the QueryResult model and the deletion logic in redash/models/ init .py around lines 304-309. The issue suggests nullifying the latest query data id when a query result is deleted. Review the database constraints and ensure no foreign key issues. Consider adding a migration if needed. Also check if there are any existing tests for this scenario.