garris/BackstopJS

approve button doesn't update reference image in UI

Open

#1.194 geöffnet am 18. Mai 2020

Auf GitHub ansehen
 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (6.510 Stars) (601 Forks)batch import
help wanted

Beschreibung

I am seeing an issue where using approve button doesn't update reference image in the report UI -- however, it does successfully run the approve on the back end -- so this is just a UI issue.

This is most noticeable when you've run backstop for the first time as with the sanity test described here... https://github.com/garris/BackstopJS#sanity-test-does-backstop-work-in-my-environment

Here is what it looked like for me. I expected the reference image column to be updated with the test image... approve does not load approved image or clean up warning

Run this command to try it yourself...

mkdir backstopSanityTest; cd backstopSanityTest; npm install backstopjs; node ./node_modules/backstopjs/cli/ init; node ./node_modules/backstopjs/cli/ remote & node ./node_modules/backstopjs/cli/ test && fg

The above script will create a test directory, install backstop, start a remote process and run a test. Once the test completes it the terminal will bring the remote process to the foreground so you can kill it when you're done testing.

Contributor Guide

Tech Stack
javascripthtmlcss
Domain
frontendtesting
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
2
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
JavaScriptBackstopJS basicsHTML/CSS
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
80
Research-Richtung
Investigate the UI code that handles the approve button click event. The backend approve works, so the frontend likely fails to update the reference image state or re fetch the image. Look for the relevant component in the report UI, likely in the 'compare' or 'approve' module. There is one comment on the issue that may provide additional context.