frintjs/frint

Match package versions after hoisting

Open

#402 geöffnet am 12. Jan. 2018

Auf GitHub ansehen
 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (746 Stars) (37 Forks)batch import
help wanted

Beschreibung

Since we introduced $ lerna bootstrap --hoist, we now notice that versions of some third-party dependencies within the packages do not match the versions as defined in root package.json.

We need to fix them.

lerna WARN EHOIST_ROOT_VERSION The repository root depends on react@^16.0.0, which differs from the more common react@^15.5.4.
lerna WARN EHOIST_PKG_VERSION "frint-react-server" package depends on react@^15.5.4, which differs from the hoisted react@^16.0.0.
lerna WARN EHOIST_ROOT_VERSION The repository root depends on react-dom@^16.0.0, which differs from the more common react-dom@^15.5.4.
lerna WARN EHOIST_PKG_VERSION "frint-react-server" package depends on react-dom@^15.5.4, which differs from the hoisted react-dom@^16.0.0.
lerna WARN EHOIST_PKG_VERSION "frint-cli" package depends on lodash@^4.17.4, which differs from the hoisted lodash@^4.13.1.
lerna WARN EHOIST_PKG_VERSION "frint-router" package depends on lodash@^4.17.4, which differs from the hoisted lodash@^4.13.1.

Contributor Guide

Tech Stack
javascriptnodejs
Domain
build systemdeveloper experience
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
half day
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
mostly clear
Voraussetzungen
Understanding of lerna monorepoBasic knowledge of npm versioningFamiliarity with frint project structure
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
40
Research-Richtung
The issue lists warnings about version mismatches after hoisting. The fix involves updating the package.json files in the affected packages: for frint react server, change react@^15.5.4 to ^16.0.0 and react dom@^15.5.4 to ^16.0.0; for frint cli and frint router, update lodash@^4.13.1 to ^4.17.4. Run `lerna bootstrap hoist` to verify the warnings are resolved. Ensure no other packages have similar mismatches.