fin-hypergrid/core

No way of temporarily displaying a grid and removing it, as clean up isn't implemented

Open

#629 geöffnet am 16. Sept. 2017

Auf GitHub ansehen
 (4 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (148 Forks)batch import
bughelp wanted

Repository-Metriken

Stars
 (892 Stars)
PR-Merge-Metriken
 (Keine gemergten PRs in 30 T)

Beschreibung

Hi,

Thanks for a great library! :-) I've created some proof-of-concepts at work using the older version.

Right now I'm looking to open a "widget" (terrible name I know) that contains a grid. The user can close the widget. Therefore, it needs to have its resources cleaned up.

grid.stopPaintThread() and grid.stopResizeThread() are not hooked up correctly and throw.

I can call grid.canvas.stopPaintLoop() successfully to stop hooking into requestAnimationFrame instead.

However, there is currently no way to remove the document level events that the canvas hooks up. This causes exceptions to be thrown once the element containing the div is removed from the page.

See: https://github.com/fin-hypergrid/core/blob/master/src/lib/Canvas.js#L53

Contributor Guide