facebookarchive/prepack

Make all files flow strict...

Open

#1.941 geöffnet am 11. Mai 2018

Auf GitHub ansehen
 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (520 Forks)batch import
help wantedrefactoring

Repository-Metriken

Stars
 (14.268 Stars)
PR-Merge-Metriken
 (Keine gemergten PRs in 30 T)

Beschreibung

... one by one.

Flow recently got a "strict" mode. We should make all our files "flow strict". This is the master issue to track progress until all files are flow strict.

We introduced flow strict to Prepack in #1692, and made the first file flow strict: https://github.com/facebook/prepack/pull/1692/files#diff-5c8b199a98cb05fcfa67ad0a331c165b

So, for each files, this starts by changing

* @flow */

to

* @flow strict */

and then fixing up the type errors (if any) that will emerge when running

yarn flow

One practical problem is that we have a giant cycle, and strict files can only import other strict files.

Contributor Guide