facebookarchive/prepack

Make all files flow strict...

Open

#1.941 geöffnet am 11. Mai 2018

Auf GitHub ansehen
 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (14.268 Stars) (520 Forks)batch import
help wantedrefactoring

Beschreibung

... one by one.

Flow recently got a "strict" mode. We should make all our files "flow strict". This is the master issue to track progress until all files are flow strict.

We introduced flow strict to Prepack in #1692, and made the first file flow strict: https://github.com/facebook/prepack/pull/1692/files#diff-5c8b199a98cb05fcfa67ad0a331c165b

So, for each files, this starts by changing

* @flow */

to

* @flow strict */

and then fixing up the type errors (if any) that will emerge when running

yarn flow

One practical problem is that we have a giant cycle, and strict files can only import other strict files.

Contributor Guide

Tech Stack
javascript
Domain
tooling
Issue Type
refactor
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
over 1 week
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
mostly clear
Voraussetzungen
JavaScriptFlow type system
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
20
Research-Richtung
This master issue tracks converting all Prepack files to Flow strict mode. The task involves changing @flow to @flow strict and fixing resulting type errors. The main challenge is a circular dependency between files that prevents strict mode propagation. The first conversion was done in PR #1692. Start by examining that PR and then pick a file outside the cycle to convert, or discuss with maintainers how to break the cycle. Since the repository is archived, further work may not be accepted.