facebookarchive/draft-js

Edge case - Paste doesn't remove current selection before mouseup

Open

#991 geöffnet am 31. Jan. 2017

Auf GitHub ansehen
 (4 Kommentare) (1 Reaktion) (0 zugewiesene Personen)JavaScript (22.554 Stars) (2.646 Forks)batch import
bughelp wanted

Beschreibung

Do you want to request a feature or report a bug? Bug.

What is the current behavior? Editor does not remove selection when pasting unless mouseup has fired (it seems that a selection isn't registered until mouseup). I use a trackpad with 3 finger drag, which has a 300-ish millisecond delay after lifting. If I paste text in that window, the following behavior occurs:

draft-js

Basically, the repro steps are:

  1. Click and drag a selection
  2. Press cmd-P before mouseup

What is the expected behavior? Paste removes currently selected text (potentially not possible). Perhaps it could disallow pasting before mouseup?

Honestly, even OS X gets this wrong. Try the same steps on the location bar.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js? DraftJS: 0.10.0 Browser: Chrome 56 OS: Mac OS X 10.12.2

Contributor Guide

Tech Stack
javascriptreact
Domain
frontend
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
ReactDraft.js basics
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
20
Research-Richtung
The issue describes a bug where pasting text before mouseup does not remove the current selection. This is likely related to Draft.js clipboard handling in `DraftEditorPasteHandler` or `editOnPaste`. The fix may involve deferring paste action until selection is registered, or checking for selection state on paste. The repository is archived, so no maintainer response is expected.