facebookarchive/draft-js

Test to verify focus/scroll behavior

Open

#1.402 geöffnet am 22. Sept. 2017

Auf GitHub ansehen
 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (22.554 Stars) (2.646 Forks)batch import
help wantedtest coverage

Beschreibung

We have twice now had an issue where a change in Chrome breaks the scroll/focus behavior of Draft. See issues #14 and now https://github.com/facebook/draft-js/issues/1381.

It might not be easy, but I'd really like to get this covered by a test, so that we can know if/when it breaks again. Ideally would like both a unit test for focusNode in fbjs and a test that only uses the public API of Draft.js and reproduces an example similar to the one given in https://github.com/facebook/draft-js/issues/1381 .

It's true that these test would only start failing when run in the browser that has the inconsistency, but still would make it faster to verify and fix this type of problem.

Contributor Guide

Tech Stack
javascriptreact
Domain
frontendtesting
Issue Type
test
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-2 days
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Familiarity with Draft.js public APIExperience with unit testing frameworksKnowledge of browser scroll/focus behavior
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
40
Research-Richtung
The issue requests two tests: a unit test for `focusNode` in fbjs (https://github.com/facebook/fbjs/blob/master/packages/fbjs/src/core/dom/focusNode.js) and a test using Draft.js public API to reproduce the scroll/focus issue from #1381 (https://github.com/facebook/draft js/issues/1381). Look at the linked issues #14 and #1381 for reproduction steps. The tests should be added to the Draft.js test suite. Since the repo is archived, ensure compatibility with existing test infrastructure.