facebookarchive/draft-js

EditorState.set() Selection Handling

Open

#1.161 geöffnet am 22. Apr. 2017

Auf GitHub ansehen
 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (22.554 Stars) (2.646 Forks)batch import
documentationhelp wanted

Beschreibung

Do you want to request a feature or report a bug?

Bug (or documentation issue)

What is the current behavior?

EditorState.set() doesn't handle selection.

Steps to reproduce: https://jsfiddle.net/7bsqzmfg/10/

What is the expected behavior?

Either EditorState.set() should handle selection or we should mention that it is not supposed to handle selection on the docs.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

Draft.js 0.10.0 Google Chrome 57.0.2987.133 macOS Sierra 10.12.3 (16D32)

Contributor Guide

Tech Stack
javascriptreact
Domain
frontenddocumentation
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
mostly clear
Voraussetzungen
Basic understanding of ReactFamiliarity with Draft.js EditorState
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
40
Research-Richtung
The issue reports that EditorState.set() does not handle selection, with a reproduction in JSFiddle. The repository is archived (facebookarchive/draft js), so any fix would need to be applied to a fork. To proceed, locate the EditorState.set() method in the source (likely src/model/immutable/EditorState.js) and examine how selection is currently handled. Check if the method should preserve selection from the previous state or if the documentation should clarify that selection is not handled. Also review any existing comments in the issue or related issues. Consider both fixing the behavior and updating documentation accordingly.