facebook/TestSlide

Simplify typehints

Open

#248 geöffnet am 2. Okt. 2020

Auf GitHub ansehen
 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Python (58 Forks)auto 404
easyenhancementgood first issuehelp wanted

Repository-Metriken

Stars
 (147 Stars)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

As per @fornellas comments on #246 do these:

  • Unions of BaseException & other exception types (eg: Exception). Shouldn't BaseException be enough? All Python exception are subclasses of it, I think it should work just fine with only it.

  • There are lots of Callable types (no args, no return) or Callable[[a,b,c...], d], mostly related to DSL hooks, such as examples, before / after hooks etc. TBH, this PR is awesome as it is, but I was thinking about having custom types such as ExampleFunction = Callable[[_ContextData], None] (non-blocking here to be clear).

Contributor Guide