facebook/TestSlide

Add `--fail-if-warning`

Open

#195 geöffnet am 26. Juni 2020

Auf GitHub ansehen
 (4 Kommentare) (2 Reaktionen) (0 zugewiesene Personen)Python (58 Forks)auto 404
Hacktoberfestenhancementhelp wanted

Repository-Metriken

Stars
 (147 Stars)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

Let's add an option --fail-if-warning, which'll look over issued warnings during test execution and fail them if warning issued. This can probably be done easily by patching Python's warning method and checking if it was called.

I see 3 cases to check for warnings:

1 - When importing test modules. 2 - When running individual tests. 3 - On shutdown.

For 1 & 2, this should be easy, not sure about 3.

An important feature of this, is to allow include / exclude paths to accept / ignore warnings. Eg: if a warning came from a third party library, there's sometimes little one can do, and we should ignore it. If warning came from the code being tested, it should surface.

Contributor Guide