[logger] `log.debug` and `.trace` should prefer the lazy implementation

(3 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)TypeScript (8.021 Forks)batch import

Feature:LoggingTeam:Coregood first issue

Repository-Metriken

There are many places where we do patterns like log.debug(`${JSON.stringify({...})}`) in the Kibana code.

When the log level is set higher than debug, this implies unnecessary CPU blocks only to be discarded later.

We should audit all use cases like this and change them to the lazy form: ``````log.debug(() => ${JSON.stringify({...})})```.

@dgieselaar provided the following RegExp to find all use cases:

\.(?:debug|trace)\(\s*(?!((?:\([^)]*\)|\w+)\s*=>)).*?JSON\.stringify\s*\(

Please, bear in mind that some loggers don't support this. Make sure to only update the ones using the Logger from @kbn/logger.

Ideally, an autofixable ESlint rule would prevent this from happening again.

Research-Richtung: Verwende den bereitgestellten RegExp, um alle log.debug und log.trace Aufrufe zu finden, die JSON.stringify eifrig verwenden. Ersetze sie durch die faule Form mit einem Callback. Stelle sicher, dass der Logger von @kbn/logger stammt.
Tech Stack: typescript
Domain: backend
Issue Type: Performance
Schwierigkeit: 3
Geschätzte Zeit: Halber Tag
Aktivitätsstatus: Aktiv
Klarheit: Klar
Voraussetzungen: TypeScript
Einsteigerfreundlichkeit: 70