eclipse-theia/theia

Eclipse Keybindings Extensions has no Effect

Offen

#5.113 geöffnet am 10.05.2019

 (6 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)TypeScript (2.478 Forks)batch import
bughelp wantedkeybindingsvscode

Repository-Metriken

Stars
 (18.676 Sterne)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

The Eclipse keymap extension for VS Code registers two bindings for "ctrl-shift-f". The declaration only differs in their "when" clause:

            {
                "mac": "cmd+shift+f",
                "win": "ctrl+shift+f",
                "linux": "ctrl+shift+f",
                "key": "ctrl+shift+f",
                "command": "editor.action.formatSelection",
                "when": "editorTextFocus && editorHasSelection"
            },
            {
                "mac": "cmd+shift+f",
                "win": "ctrl+shift+f",
                "linux": "ctrl+shift+f",
                "key": "ctrl+shift+f",
                "command": "editor.action.formatDocument",
                "when": "editorTextFocus && !editorHasSelection"
            },

I believe this is valid according to https://code.visualstudio.com/docs/getstarted/keybindings, but at startup I get an error (below) and initialization of the plugin seems to fail (Eclipse shortcuts are not present, like "ctrl-g".

root WARN Collided keybinding is ignored;  {"command":"editor.action.formatDocument","keybinding":"ctrl+shift+f"}  collided with  {"command":"editor.action.formatSelection","keybinding":"ctrl+shift+f"}
root WARN Could not register keybinding:
  {"command":"editor.action.formatDocument","keybinding":"ctrl+shift+f"}
Error: "ctrl+shift+f" is in collision with something else [scope:1]
root INFO [hosted-plugin: 29136] PLUGIN_HOST(29136): PluginManagerExtImpl/init()

root INFO [hosted-plugin: 29136] PLUGIN_HOST(29136): initializing(/home/thomas/chedev/theia/packages/plugin-ext-vscode/lib/node/plugin-vscode-init.js)

Contributor Guide