eclipse-jdt/eclipse.jdt.core

Follow up on minimal target change to 1.8

Open

#2.761 geöffnet am 25. Juli 2024

Auf GitHub ansehen
 (0 Kommentare) (1 Reaktion) (0 zugewiesene Personen)Java (183 Forks)auto 404
compilerhelp wanted

Repository-Metriken

Stars
 (233 Stars)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

Open TODO's from https://github.com/eclipse-jdt/eclipse.jdt.core/pull/2551

Created issues:

Following questions wait for answering by others:

  • [Stephan] Should this.currentProject.setOption(JavaCore.COMPILER_PB_RAW_TYPE_REFERENCE, JavaCore.IGNORE); be used in ConverterTestSetup.setUpJavaProject(String, String) ?
  • [Stephan]: change on BatchCompilerTest.testBridgeMethodRetention This change probably conflicts with the purpose of this test, @srikanth-sankaran ?
  • [Stephan] Change in ASTConverterTestAST8_2.test0612() caught me by surprise so I investigated:
    • the test implies to test AST at JLS8
    • using source from project Converter, Converter15, however, selects the AST level from the project. @srikanth-sankaran , @jarthana does it make any sense have such tests here? Shouldn't tests always sit in a test class corresponding to the used Converter* project, e.g., ASTConverterAST3Test?

Contributor Guide