dotnet/roslyn
CSharpSyntaxGenerator doesn't appear to simplify when generating an attribute on a local function
Offen
#52.039 geöffnet am 22.03.2021
Area-CompilersConcept-Continuous ImprovementFeature - Local Functionshelp wanted
Repository-Metriken
- Stars
- (20.414 Sterne)
- PR-Merge-Metriken
- (Durchschn. Merge 6T 17h) (256 gemergte PRs in 30 T)
Beschreibung
I wrote the following code to add attributes to particular declarations
var editor = new SyntaxEditor (root, document.Project.Solution.Workspace);
var generator = editor.Generator;
var semanticModel = await document.GetSemanticModelAsync (cancellationToken).ConfigureAwait (false);
if (semanticModel is null) {
return document;
}
var methodSymbol = (IMethodSymbol) semanticModel.GetDeclaredSymbol (methodDecl);
var name = semanticModel.GetSymbolInfo (targetNode).Symbol?.Name;
SyntaxNode[] attrArgs;
if (string.IsNullOrEmpty (name) || HasPublicAccessibility (methodSymbol)) {
attrArgs = Array.Empty<SyntaxNode> ();
} else {
attrArgs = new[] { generator.LiteralExpression ($"calls {name}") };
}
var newAttribute = generator
.Attribute (generator.TypeExpression (requiresUnreferencedCodeSymbol), attrArgs)
.WithAdditionalAnnotations (
Simplifier.Annotation,
Simplifier.AddImportsAnnotation);
editor.AddAttribute (methodDecl, newAttribute);
return document.WithSyntaxRoot (editor.GetChangedRoot ());
This generates an attribute correctly for local functions, but the type name is always fully qualified. Declaration forms that are not local functions appear to work correctly.