dotnet/roslyn

Xml doc comment for ManagedCompiler.GenerateResponseFileCommands is wrong

Open

#4.597 geöffnet am 17. Aug. 2015

Auf GitHub ansehen
 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)C# (4.257 Forks)batch import
Area-CompilersBugDocumentationhelp wanted

Repository-Metriken

Stars
 (20.414 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 6T 17h) (256 gemergte PRs in 30 T)

Beschreibung

From ManagedCompiler.cs:

/// <summary> 
/// Returns the command line switch used by the tool executable to specify the response file 
/// Will only be called if the task returned a non empty string from GetResponseFileCommands 
/// Called after ValidateParameters, SkipTaskExecution and GetResponseFileCommands 
/// </summary> 
protected override string GenerateResponseFileCommands() 
{ 
    CommandLineBuilderExtension commandLineBuilder = new CommandLineBuilderExtension(); 
    AddResponseFileCommands(commandLineBuilder); 
    return commandLineBuilder.ToString(); 
} 

The summary comment claims the method returns the command line switch used to introduce a response file. But in fact it seems to return the contents of the response file. It also mentions a GetResponseFileCommands method that doesn't appear to be defined anywhere.

Contributor Guide