dotnet/roslyn

Deconstructed variables code fix should always camelCase variables

Open

#23.716 geöffnet am 11. Dez. 2017

Auf GitHub ansehen
 (9 Kommentare) (1 Reaktion) (0 zugewiesene Personen)C# (4.257 Forks)batch import
Area-IDEFeature - Tupleshelp wanted

Repository-Metriken

Stars
 (20.414 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 6T 17h) (256 gemergte PRs in 30 T)

Beschreibung

class Program
{
    private static readonly (string Factory, string EvaluationRuleName) Foo;

    static void Main(string[] args)
    {
        var foo = Foo; // Deconstruct tuple here


    }
}

Expected:

class Program
{
    private static readonly (string Factory, string EvaluationRuleName) Foo;

    static void Main(string[] args)
    {
        var (factory, evaluationRuleName) = Foo;
    }
}

Actual:


class Program
{
    private static readonly (string Factory, string EvaluationRuleName) Foo;

    static void Main(string[] args)
    {
        var (Factory, EvaluationRuleName) = Foo;

    }
}

Because tuple names appear as public fields when you access them via the tuple itself, it's common practice to PascalCase them in a declaration. However, when they are deconstructed into variables - you want them them to be camelCase to match the naming style for variables.

Either add an option here that I can switch or change the behavior. As it stands, I can't use this code fix.

Contributor Guide